Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve log4j ContextDataProvider injection #5216

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Improve log4j ContextDataProvider injection #5216

merged 1 commit into from
Jan 26, 2022

Conversation

trask
Copy link
Member

@trask trask commented Jan 25, 2022

Thanks to #5185

@trask trask requested a review from a team January 25, 2022 19:14
anuraaga
anuraaga approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

mateuszrzeszutek
mateuszrzeszutek approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@trask trask merged commit a5e0696 into open-telemetry:main Jan 26, 2022
@trask trask deleted the improve-log4j-context-data-provider-injection branch January 26, 2022 17:26
@pleeplop pleeplop mentioned this pull request Feb 28, 2022
Closed
This was referenced Feb 28, 2022
Merged
Closed
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@trask @RashmiRam
Improve log4j ContextDataProvider injection (open-telemetry#5216)
002039f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trask @anuraaga @mateuszrzeszutek