Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http.route in HttpServerMetrics #5266

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

mateuszrzeszutek
Copy link
Member

This PR actually resolves #442 , i.e. it finishes the implementation of the http.route attribute in both metrics and traces. It's still a quite messy solution though; I'll try to refactor it and implement necessary Instrumenter API changes in the following PRs.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team January 28, 2022 11:36
@mateuszrzeszutek
Copy link
Member Author

@trask Do you think we can remove the fallback from TemporaryMetricsView now?

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask Do you think we can remove the fallback from TemporaryMetricsView now?

👍

@trask trask merged commit 666c22e into open-telemetry:main Jan 31, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the http-route-metrics branch February 1, 2022 06:25
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Use http.route in HttpServerMetrics

* remove http.target fallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http.route attribue
2 participants