Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid having two tasks producing the same file #5302

Closed
wants to merge 1 commit into from

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Feb 3, 2022

No description provided.

@iNikem iNikem requested a review from a team February 3, 2022 09:21
// We don't publish this jar file, so the actual classifier value is not important.
// But we should not have two tasks (jar and shadow) that produce the same file.
jar {
archiveClassifier.set("slim")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking suggestions for the classifier value :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty-do-not-use? 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering #5251 slim doesn't look like the best name for now. If this is an intermediate jar that isn't really functional then maybe -tmp or something else that hints that this is not supposed to be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now only to understand, why smoke test crashes...

// We don't publish this jar file, so the actual classifier value is not important.
// But we should not have two tasks (jar and shadow) that produce the same file.
jar {
archiveClassifier.set("slim")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty-do-not-use? 😄

@iNikem
Copy link
Contributor Author

iNikem commented Feb 3, 2022

@trask I think that #5129 was a mistake:

First, jar is NOT needed for producing javadoc and source jars, they are totally independent.
Second, by having jar task with a classifier, that jar gets published and thus examples get that thin jar when they request io.opentelemetry.javaagent:opentelemetry-javaagent.
Third, if we have jar without any classifier, then things kinda work, but only by accident. See (#4765 (comment)).

What was the failure that #5129 tried to solve? I still think that #4765 was and is correct.

@trask
Copy link
Member

trask commented Feb 3, 2022

What was the failure that #5129 tried to solve?

maven central publishing failed during release because there was no -javadoc or -sources artifact for the opentelemetry-javaagent artifact, so I just reverted #4765, but I'm good with solving it a different way

@iNikem
Copy link
Contributor Author

iNikem commented Feb 4, 2022

I will postpone this change. Don't want to mess with release process while my brain is 90% elsewhere...

@iNikem iNikem marked this pull request as draft February 4, 2022 08:00
@anuraaga
Copy link
Contributor

anuraaga commented Feb 10, 2022

I had issues with jmx-metrics project in contrib being slow due to the same issue so looked into this, should be superceded by #5334

@anuraaga anuraaga closed this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants