Rename netty always-create-connect-span property to `connection-tel…
#5834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Apr 14, 2022
laurit
reviewed
Apr 14, 2022
| static { | ||
| Config config = Config.get(); | ||
| boolean alwaysCreateConnectSpan = | ||
| config.getBoolean("otel.instrumentation.netty.always-create-connect-span", false); |
There was a problem hiding this comment.
Should we try to communicate to users that they are using a deprecated property? Or will we just document the deprecation in release notes?
There was a problem hiding this comment.
Hmm, we've probably never done that before, but that's a good idea - @open-telemetry/java-instrumentation-approvers WDYT about adding a warning log if a deprecated property is used?
trask
approved these changes
Apr 14, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
open-telemetry#5834) * Rename netty `always-create-connect-span` property to `connection-telemetry` * formatting * warn when deprecated property is used * errorprone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emetry`
This should make it more uniform and similar to
ssl-telemetry,controller-telemetryetc.