Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DataDirect and Tibco Jdbc URLs #6420

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Support DataDirect and Tibco Jdbc URLs #6420

merged 1 commit into from
Aug 9, 2022

Conversation

trask
Copy link
Member

@trask trask commented Aug 5, 2022

Resolves #6400

@trask trask requested a review from a team August 5, 2022 04:38
String subtype = jdbcUrl.substring(typeEndIndex + 1, subtypeEndIndex);
builder.subtype(subtype);

if (subtype.equals("sqlserver")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these all possible subtypes? or could you have something like jdbc:datadirect:mariadb://server_name:3306?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all of the subtypes are listed here: https://docs.progress.com/bundle/datadirect-connect-jdbc-51/page/URL-Formats-DataDirect-Connect-for-JDBC-Drivers.html (I didn't include support for sybase or informix in the PR).

(my understanding is that these are real drivers as opposed to wrappers)

@trask trask merged commit 0804fef into open-telemetry:main Aug 9, 2022
@trask trask deleted the support-tibco-jdbc-url branch August 9, 2022 00:13
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support datadirect and tibco jdbc urls
3 participants