Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spring boot @WithSpan handling #6619

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Sep 14, 2022

Resolves #6617
Spring detects aspects by checking whether predicted bean type is annotated with @Aspect. WithSpanAspect isn't, but the subclasses are.

@laurit laurit requested a review from a team September 14, 2022 15:39
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #6620 to track adding a regression test for this since seems like something easy for us to break

@trask trask added this to the v1.18.0 milestone Sep 14, 2022
@trask trask merged commit 5afd6b3 into open-telemetry:main Sep 14, 2022
@laurit laurit deleted the spring-withspan branch September 15, 2022 10:37
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spring-boot starter @WithSpan auto instrumentation not working on 1.17.0
3 participants