Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the sampling API to take a parent Context, rather than SpanContext #1840

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

jkwatson
Copy link
Contributor

See this recent spec update: open-telemetry/opentelemetry-specification#881

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #1840 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1840   +/-   ##
=========================================
  Coverage     85.51%   85.51%           
  Complexity     1442     1442           
=========================================
  Files           177      177           
  Lines          5571     5572    +1     
  Branches        578      578           
=========================================
+ Hits           4764     4765    +1     
  Misses          606      606           
  Partials        201      201           
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/opentelemetry/sdk/trace/Sampler.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/io/opentelemetry/sdk/trace/SpanBuilderSdk.java 96.80% <ø> (ø) 31.00 <0.00> (ø)
...ions/trace/jaeger/sampler/JaegerRemoteSampler.java 74.50% <ø> (ø) 9.00 <0.00> (ø)
...ions/trace/jaeger/sampler/PerOperationSampler.java 75.00% <ø> (ø) 4.00 <0.00> (ø)
...main/java/io/opentelemetry/sdk/trace/Samplers.java 77.67% <100.00%> (+0.20%) 14.00 <0.00> (ø)
...ions/trace/jaeger/sampler/RateLimitingSampler.java 69.56% <100.00%> (ø) 7.00 <3.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def5a23...b86cb85. Read the comment docs.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno why this looks like dejavu

@anuraaga anuraaga merged commit f20b3d7 into open-telemetry:master Oct 21, 2020
@lzchen
Copy link

lzchen commented Oct 21, 2020

@jkwatson
You guys are so fast!

@jkwatson jkwatson deleted the sampling_context branch October 21, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants