Update semantic convention constants generator script and template #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
requested review from
anuraaga,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
arminru
commented
Mar 19, 2021
jkwatson
previously requested changes
Mar 19, 2021
arminru
force-pushed
the
semconvgen-update
branch
from
8cc1215
to
b24970e
Compare
jkwatson
pushed a commit
to jkwatson/opentelemetry-java
that referenced
this pull request
Apr 9, 2021
|
ok, the spec has now had 1.2.0 released, so this can move forward. @arminru do you want to update it, or should I open a new one with your changes included? |
…pec reference The template was updated to reflect the changes introduced in otel/semconvgen v0.3.0 and v0.3.1. The script was updated to pin the version of the otel/semconvgen image, otherwise incompatible updates would break it. Fixes open-telemetry#3042.
The template was updated to use the correct base definitions, so the Javadoc for some attributes changed (the ones for `rpc.*`, for example). This also changed the ordering but it is still reproducible.
arminru
force-pushed
the
semconvgen-update
branch
from
b24970e
to
5256ef0
Compare
|
@jkwatson I rebased and updated the PR. |
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3042.