Implement OpenTracing Shim specifying custom propagators #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergei Malafeev <[email protected]>
malafeev
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
Signed-off-by: Sergei Malafeev <[email protected]>
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/Propagators.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/Propagators.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/Propagators.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/Propagators.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/Propagators.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/test/java/io/opentelemetry/opentracingshim/SpanShimTest.java
Outdated
Show resolved
Hide resolved
|
Left a few small comments. Overall LGTM. Thanks! |
Signed-off-by: Sergei Malafeev <[email protected]>
Signed-off-by: Sergei Malafeev <[email protected]>
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/OpenTracingPropagators.java
Outdated
Show resolved
Hide resolved
...acing-shim/src/main/java/io/opentelemetry/opentracingshim/OpenTracingPropagatorsBuilder.java
Outdated
Show resolved
Hide resolved
carlosalberto
approved these changes
Mar 26, 2021
Signed-off-by: Sergei Malafeev <[email protected]>
jkwatson
reviewed
Mar 29, 2021
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/OpenTracingPropagators.java
Outdated
Show resolved
Hide resolved
jkwatson
reviewed
Mar 29, 2021
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/OpenTracingPropagators.java
Show resolved
Hide resolved
jkwatson
reviewed
Mar 29, 2021
...acing-shim/src/main/java/io/opentelemetry/opentracingshim/OpenTracingPropagatorsBuilder.java
Show resolved
Hide resolved
jkwatson
reviewed
Mar 29, 2021
...acing-shim/src/main/java/io/opentelemetry/opentracingshim/OpenTracingPropagatorsBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergei Malafeev <[email protected]>
jkwatson
reviewed
Mar 30, 2021
| new TelemetryInfo( | ||
| getTracer(GlobalOpenTelemetry.getTracerProvider()), | ||
| GlobalOpenTelemetry.getPropagators())); | ||
| return createTracerShim(getTracer(GlobalOpenTelemetry.getTracerProvider())); |
There was a problem hiding this comment.
I don't see any way here to actually use custom propagators. As far as I can see, we only every use the standard stuff in GlobalOpenTelemetry or the OpenTelemetry instance passed in directly. Are we missing a creational method here that will allow passing in custom OpenTracingPropagators somewhere?
Signed-off-by: Sergei Malafeev <[email protected]>
anuraaga
approved these changes
Mar 31, 2021
jkwatson
reviewed
Mar 31, 2021
| * | ||
| * @return a {@code io.opentracing.Tracer}. | ||
| */ | ||
| public static io.opentracing.Tracer createTracerShim( |
There was a problem hiding this comment.
3 creational methods make me think we should be using a builder. any thoughts about that? It could definitely be done as a follow-up PR.
There was a problem hiding this comment.
even 4.
maybe leave only two by removing createTracerShim(OpenTelemetry openTelemetry) and createTracerShim() ?
@carlosalberto ?
There was a problem hiding this comment.
Good call. Let's do that in a follow up. @malafeev would you mind creating an issue for that, so we don't forget, before merging this PR?
jkwatson
approved these changes
Mar 31, 2021
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3049
spec: https:/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opentracing.md#create-an-opentracing-tracer-shim