Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log processors to the builder so LogSinkSdkProvider is immutable #3751

Merged

Conversation

jack-berg
Copy link
Member

Log processors should be added to the builder. LogSinkSdkProvider should be immutable.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #3751 (b4950f6) into main (9b9dcf9) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3751      +/-   ##
============================================
+ Coverage     89.21%   89.29%   +0.08%     
- Complexity     3877     3880       +3     
============================================
  Files           464      464              
  Lines         12136    12139       +3     
  Branches       1189     1189              
============================================
+ Hits          10827    10840      +13     
+ Misses          916      910       -6     
+ Partials        393      389       -4     
Impacted Files Coverage Δ
.../io/opentelemetry/sdk/logs/LogSinkSdkProvider.java 100.00% <100.00%> (ø)
...ntelemetry/sdk/logs/LogSinkSdkProviderBuilder.java 100.00% <100.00%> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 90.78% <0.00%> (+0.70%) ⬆️
...ntelemetry/sdk/extension/resources/OsResource.java 90.69% <0.00%> (+4.65%) ⬆️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️
...metry/sdk/extension/resources/ProcessResource.java 87.50% <0.00%> (+6.25%) ⬆️
...elemetry/sdk/extension/resources/HostResource.java 92.30% <0.00%> (+15.38%) ⬆️
...dk/extension/resources/ProcessRuntimeResource.java 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9dcf9...b4950f6. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@jkwatson jkwatson merged commit c706293 into open-telemetry:main Oct 18, 2021
This was referenced Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants