Add TestLogData, remove public LogDataImpl and LogDataBuilder from log SDK #4635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on refactoring some of the Log SDK to allow modifying log records in
LogProcessor
for #4550 (related spec PR 2681). I have a commit that includes all the necessary changes to make this happen, but in an effort to make the review more manageable, have split out one of the changes into this PR.Currently there is a a single
LogData
interface which is accepted byLogProcessor
andLogExporter
. The goal is to instead pass aReadWriteLogRecord
interface (akin toReadWriteSpan
) toLogProcessor
, while reservingLogData
forLogExporter#export
. This PR removes the publicLogDataImpl
andLogDataBuilder
classes from the Log SDK, replacing them with aTestLogData
autovalue class in:sdk:logs-testing
for testing purposes. This makesLogData
much more in line withSpanData
.