Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes resource attribute in
target_info
metric. Previously attempted in #4569. This has been discussed in the spec and by the prometheus WG and the spec is unambiguous. We really need to get this behavior implemented.Example:
Serialize scope as
otel_scope_info
metric. Include scope name and version attributes on each metric to disambiguate from metrics with the same name in different scopes. Related to #5014, but doesn't solve the collision issue.Example:
Includes a new
PrometheusHttpServerIntegrationTest
to demonstrate the behavior end to end from: SDK -> collector prometheus receiver -> collector OTLP exporter -> mock OTLP server.Our prometheus exporter is really starting to fall behind the spec. This PR is the first of a couple needed to get it back on course.