Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isRemote to the SpanContext #626

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Add isRemote to the SpanContext #626

merged 1 commit into from
Oct 24, 2019

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Oct 24, 2019 •
edited by arminru
Loading

@jkwatson
Copy link
Contributor

Is there a relevant spec or OTEP reference we can include with the PR?

@arminru
Copy link
Member

arminru commented Oct 24, 2019

@jkwatson

Is there a relevant spec or OTEP reference we can include with the PR?

I added a reference to open-telemetry/opentelemetry-specification#216

@bogdandrutu bogdandrutu merged commit 0b21928 into open-telemetry:master Oct 24, 2019
@bogdandrutu bogdandrutu deleted the isremote branch October 24, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwatson jkwatson jkwatson left review comments

@arminru arminru arminru approved these changes

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@songy23 songy23 Awaiting requested review from songy23

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @jkwatson @arminru