Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove android animalsniffer check from prometheus exporter #6478

Merged

Conversation

jack-berg
Copy link
Member

It doesn't make sense to scrape metrics from an android device. Furthermore, the android API doesn't contain com.sun.net.httpserver.HttpHandler and this is a key part of the implementation of prometheus. So animalsniffer checks for usages of unsupported APIs directly, it doesn't appear to walk all the code paths so it missed this usage in the prometheus client library dependency.

See convo in #6476 for more details.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (cdcc58c) to head (4720b0d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6478   +/-   ##
=========================================
  Coverage     90.86%   90.86%           
  Complexity     6169     6169           
=========================================
  Files           678      678           
  Lines         18511    18511           
  Branches       1818     1818           
=========================================
  Hits          16820    16820           
  Misses         1154     1154           
  Partials        537      537           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 0f99d70 into open-telemetry:main May 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants