Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename base classes to abstract class #832

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 7, 2020

Split from #831

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #832 into master will not change coverage.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #832   +/-   ##
=========================================
  Coverage     78.96%   78.96%           
  Complexity      798      798           
=========================================
  Files           106      106           
  Lines          2885     2885           
  Branches        275      275           
=========================================
  Hits           2278     2278           
  Misses          503      503           
  Partials        104      104
Impacted Files Coverage Δ Complexity Δ
.../io/opentelemetry/sdk/metrics/LongObserverSdk.java 53.84% <ø> (ø) 2 <0> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongCounterSdk.java 65.71% <ø> (ø) 5 <0> (ø) ⬇️
...o/opentelemetry/sdk/metrics/DoubleObserverSdk.java 53.84% <ø> (ø) 2 <0> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleCounterSdk.java 65.71% <ø> (ø) 5 <0> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongMeasureSdk.java 65.71% <ø> (ø) 5 <0> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java 65.71% <ø> (ø) 5 <0> (ø) ⬇️
.../opentelemetry/sdk/metrics/AbstractInstrument.java 30.43% <0%> (ø) 1 <0> (?)
...telemetry/sdk/metrics/AbstractBoundInstrument.java 50% <66.66%> (ø) 2 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a44a2...c3e56cf. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 7a832e6 into open-telemetry:master Feb 7, 2020
@bogdandrutu bogdandrutu deleted the abstract branch February 7, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants