Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryTraceContext benchmarks #840

Closed
wants to merge 24 commits into from
Closed

BinaryTraceContext benchmarks #840

wants to merge 24 commits into from

Conversation

DotSpy
Copy link
Member

@DotSpy DotSpy commented Feb 8, 2020

binary trace context benchmarks #792

@codecov-io
Copy link

codecov-io commented Feb 8, 2020 •
edited
Loading

Codecov Report

Merging #840 into master will increase coverage by 3.74%.
The diff coverage is 88.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #840      +/-   ##
============================================
+ Coverage     79.24%   82.99%   +3.74%     
- Complexity      788      837      +49     
============================================
  Files           105      108       +3     
  Lines          2848     2869      +21     
  Branches        273      253      -20     
============================================
+ Hits           2257     2381     +124     
+ Misses          487      375     -112     
- Partials        104      113       +9
Impacted Files Coverage Δ Complexity Δ
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 91.51% <ø> (ø) 45 <0> (ø) ⬇️
...o/opentelemetry/sdk/trace/export/SpanExporter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...lemetry/sdk/trace/export/SimpleSpansProcessor.java 87.5% <ø> (ø) 7 <0> (ø) ⬇️
...metry/exporters/jaeger/JaegerGrpcSpanExporter.java 67.79% <ø> (ø) 4 <0> (ø) ⬇️
...elemetry/sdk/trace/export/BatchSpansProcessor.java 89.65% <ø> (ø) 7 <0> (ø) ⬇️
...ntelemetry/sdk/trace/export/MultiSpanExporter.java 100% <ø> (ø) 12 <0> (ø) ⬇️
...ava/io/opentelemetry/exporters/jaeger/Adapter.java 96.2% <ø> (ø) 16 <0> (ø) ⬇️
...java/io/opentelemetry/sdk/trace/data/SpanData.java 100% <ø> (ø) 2 <0> (?)
...ntelemetry/exporters/inmemory/InMemoryTracing.java 85.71% <ø> (ø) 5 <0> (ø) ⬇️
...ava/io/opentelemetry/sdk/trace/SpanBuilderSdk.java 93.87% <ø> (ø) 36 <0> (ø) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a0d03...e051831. Read the comment docs.

@DotSpy
Copy link
Member Author

DotSpy commented Feb 19, 2020

Screenshot_2020-02-20 JMH Visualizer
if we will do error prone way i'll rewrite it #887

bogdandrutu and others added 17 commits February 21, 2020 18:27
@bogdandrutu @DotSpy
Move AbstractInstrumentBuilder to AbstractInstrument.Builder (open-te…
c1a3f5a 
…lemetry#884)

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@bogdandrutu @DotSpy
Rename MeterSharedState with MeterProviderSharedState (open-telemetry…
0be0f47 
…#875)

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@bogdandrutu @DotSpy
Fix javadoc in MetricExporter class (open-telemetry#885)
dcea940 
Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@bogdandrutu @DotSpy
Fix javadoc in Aggregations class (open-telemetry#886)
759d242 
Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@bogdandrutu @DotSpy
Fix errorprone errors and re-enable errorprone for jmh (open-telemetr…
9a2bb94 
…y#887)

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@bogdandrutu @DotSpy
Add an abstract helper class for all instruments with bindings (open-…
843bd7f 
…telemetry#873)

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@bogdandrutu @DotSpy
Extract descriptor fields for Instrument and use autovalue (open-tele…
27a134c 
…metry#865)

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@bogdandrutu @DotSpy
Add AllLabels Batcher and install default Barcher for Counters (open-…
91d14ae 
…telemetry#831)

* Bound registry work in progress

Signed-off-by: Bogdan Cristian Drutu <[email protected]>

* Add comment about protecting a collection cycle by a lock

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@carlosalberto @DotSpy
Use Collections.emptyList() directly. (open-telemetry#892)
b885421
@thisthat @DotSpy
Move metric check for name length (open-telemetry#893)
0010ccc
@arminru @DotSpy
Fix Javadoc about EnvVarResource (open-telemetry#894)
fbfa698 
* Fix Javadoc in EnvVarResource.java

* Update package-info.java
@thisthat @DotSpy
Rename TracerRegistry -> Tracer Provider (open-telemetry#879)
34198d3 
* Rename TracerRegistry -> Tracer Provider

* Add comment to address the provider name

* gradlew goJF
@jkwatson @DotSpy
Add instrumentation to the BatchSpansProcessor to count the number of…
152b703 
… dropped spans (open-telemetry#889)

* Add instrumentation to the BatchSpansProcessor to count the number of dropped spans.
@thisthat @DotSpy
Change Sampler interface (open-telemetry#881)
29e8b41 
* Change Sampler interface

* Fix sampler interface
@bogdandrutu @DotSpy
Use a static method to access EMPTY InstrumentationLibraryInfo. (open…
eaecfa9 
…-telemetry#897)

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@DotSpy
feat: make invalid span context public (open-telemetry#896)
5dfd9cd
@jkwatson @DotSpy
Add the enclosing interface references to remove javadoc errors (open…
71f2456 
…-telemetry#902)
bogdandrutu and others added 3 commits February 21, 2020 18:27
@bogdandrutu @DotSpy
Add a MeterSharedState class that includes the InstrumentationLibrary…
678628f 
…Info (open-telemetry#901)

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@jkwatson @DotSpy
Introduce an abstract super class for aggregators. (open-telemetry#898)
5ea5ec3 
* Introduce an abstract super class for aggregators.
This is to hold the boilerplate logic and get it out of the specific implementations.

* tighten up the access modifiers and flip the assignable logic to be correct
@DotSpy
fix: apply errorprone rules
163c48b
@DotSpy DotSpy closed this Feb 21, 2020
@DotSpy DotSpy deleted the binary_benchmark branch February 21, 2020 15:30
@DotSpy DotSpy mentioned this pull request Feb 26, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminru arminru Awaiting requested review from arminru

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@songy23 songy23 Awaiting requested review from songy23

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DotSpy @codecov-io @bogdandrutu @carlosalberto @thisthat @arminru @jkwatson