Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup jmh and trace context benchmarks #920

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

bogdandrutu
Copy link
Member

Enabled GC profiler for all the benchmarks.

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@bogdandrutu
Copy link
Member Author

/cc @DotSpy

@codecov-io
Copy link

Codecov Report

Merging #920 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #920   +/-   ##
=========================================
  Coverage     82.81%   82.81%           
  Complexity      843      843           
=========================================
  Files           113      113           
  Lines          2967     2967           
  Branches        254      254           
=========================================
  Hits           2457     2457           
  Misses          398      398           
  Partials        112      112

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9f928...ad5b8bc. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to also include hs_gc, but this is good.

@DotSpy
Copy link
Member

DotSpy commented Feb 24, 2020

good one

@bogdandrutu
Copy link
Member Author

@jkwatson we can add "hs_gc" later if we find it useful.

@bogdandrutu bogdandrutu merged commit 1f202a9 into open-telemetry:master Feb 24, 2020
@bogdandrutu bogdandrutu deleted the bench branch February 24, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants