This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
feat: make context.active() the default value for certain context functions #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions where I'm adding a default context as
context.active()
, based on searching the otel-js repo for their invocations:getSpan()
setSpan()
suppressInstrumentation()
💥 breaks
setSpan()
as it reverses the order of params.This PR also serves a discussion. Is this a better default or not?
Pros: it will reduce boilerplate code, helper functions aside/when working with lowest level api
Cons: ?