Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

feat!: return boolean success value from setGlobalXXX methods #32

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 7, 2021

Fixes #31

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #32 (61a6015) into main (9df5ef8) will decrease coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   94.64%   94.61%   -0.04%     
==========================================
  Files          39       39              
  Lines         504      501       -3     
  Branches       81       81              
==========================================
- Hits          477      474       -3     
  Misses         27       27              
Impacted Files Coverage Δ
src/internal/global-utils.ts 90.62% <66.66%> (+0.30%) ⬆️
src/api/context.ts 96.15% <100.00%> (-0.28%) ⬇️
src/api/diag.ts 100.00% <100.00%> (ø)
src/api/propagation.ts 100.00% <100.00%> (ø)
src/api/trace.ts 95.65% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df5ef8...61a6015. Read the comment docs.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be a breaking change :/ although I think this is the last chance we can really do it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return value of setGlobalXXX doesn't match documentation
5 participants