fix(instrumentation-mysql): fix test for mysql2 v3 (#2168)

Update mysql2 dependency to latest version (@3.11.3) and fix tests. Problems during `npm run compile` were fixed by removing an unsafe and incorrect typecast. Fixes #2168 Signed-off-by: Thomas Praxl <[email protected]>
open-telemetry · Sep 24, 2024 · 11f6a52 · 11f6a52
1 parent 0d6ebde
commit 11f6a52
Show file tree

Hide file tree

Showing 3 changed files with 64 additions and 68 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/plugins/node/opentelemetry-instrumentation-mysql2/package.json b/plugins/node/opentelemetry-instrumentation-mysql2/package.json
@@ -52,7 +52,7 @@
  "@types/node": "18.6.5",
  "@types/semver": "7.5.8",
  "mocha": "7.2.0",
- "mysql2": "2.3.3",
+ "mysql2": "3.11.3",
  "nyc": "15.1.0",
  "rimraf": "5.0.10",
  "semver": "7.6.3",

diff --git a/plugins/node/opentelemetry-instrumentation-mysql2/test/mysql.test.ts b/plugins/node/opentelemetry-instrumentation-mysql2/test/mysql.test.ts
@@ -54,7 +54,7 @@ interface Result extends mysqlTypes.RowDataPacket {
  solution: number;
 }
 
-describe('mysql2@2.x', () => {
+describe('mysql2', () => {
  let contextManager: AsyncHooksContextManager;
  let connection: mysqlTypes.Connection;
  let rootConnection: mysqlTypes.Connection;
@@ -148,7 +148,7 @@ describe('[email protected]', () => {
  host,
  password,
  database,
- } as mysqlTypes.PoolClusterOptions);
+ });
  });
 
  afterEach(done => {