Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detector-container): suppress internal tracing #2430

Conversation

david-luna
Copy link
Contributor

@david-luna david-luna commented Sep 12, 2024

Which problem is this PR solving?

Short description of the changes

  • suppress tracing when resolving attributes
  • add test

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (dfb2dff) to head (3ecbfc0).
Report is 240 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2430      +/-   ##
==========================================
- Coverage   90.97%   90.72%   -0.26%     
==========================================
  Files         146      156      +10     
  Lines        7492     7674     +182     
  Branches     1502     1578      +76     
==========================================
+ Hits         6816     6962     +146     
- Misses        676      712      +36     
Files with missing lines Coverage Δ
...ector-container/src/detectors/ContainerDetector.ts 95.31% <100.00%> (+2.45%) ⬆️

... and 76 files with indirect coverage changes

@david-luna david-luna merged commit 80c2f1a into open-telemetry:main Sep 13, 2024
21 checks passed
@dyladan dyladan mentioned this pull request Sep 12, 2024
@david-luna david-luna deleted the dluna/2320-container-detector-suppress-tracing branch September 23, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants