feat(opentelemetry-plugin-pg): omit pg.values by default #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR solves issue #11, that reports the PostgreSQL plugin must not log
pg.values
by default because they may contain sensitive data such as user credentials.Short description of the changes
PgClientExtended
type to inherit directly frompgTypes.Client
instead of intersect them all the time.utils.ts
to avoid generic types (...args: unknown[]
)PgPluginQueryConfig
interface toNormalizedQueryConfig
(based on the plugin) to avoid confusion.pg.values
only whenenhancedDatabaseReporting
(standard property) flag is se to true.utils.ts
instead of duplicating the assertions for each valid call.