chore: moved plugins-node-all into contrib repo from opentelemetry-js #184
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # OpenTelemetry Plugins Node All | ||
|
There was a problem hiding this comment. Fixed the naming here. It was claiming to also be "Node Core" |
||
|
|
||
| [![Gitter chat][gitter-image]][gitter-url] | ||
| [![NPM Published Version][npm-img]][npm-url] | ||
| [![dependencies][dependencies-image]][dependencies-url] | ||
| [![Apache License][license-image]][license-image] | ||
|
|
||
| This package depends on all node plugins maintained by OpenTelemetry authors. | ||
| Installing it will also install all plugins. | ||
|
|
||
| ## Plugins | ||
|
|
||
| In addition to all [node core plugins][otel-plugins-node-core], the following plugins will be installed by this package: | ||
|
|
||
| - [@opentelemetry/plugin-express][otel-plugin-express] | ||
| - [@opentelemetry/plugin-ioredis][otel-plugin-ioredis] | ||
| - [@opentelemetry/plugin-mongodb][otel-plugin-mongodb] | ||
| - [@opentelemetry/plugin-mysql][otel-plugin-mysql] | ||
| - [@opentelemetry/plugin-pg-pool][otel-plugin-pg-pool] | ||
| - [@opentelemetry/plugin-pg][otel-plugin-pg] | ||
| - [@opentelemetry/plugin-redis][otel-plugin-redis] | ||
|
|
||
| Note: [@opentelemetry/plugin-dns][otel-plugin-dns] is excluded by default because it requires some manual configuration to prevent infinite loops with exporters. | ||
|
|
||
| ## Useful links | ||
|
|
||
| - For more information on OpenTelemetry, visit: <https://opentelemetry.io/> | ||
| - For more about OpenTelemetry JavaScript: <https:/open-telemetry/opentelemetry-js> | ||
| - For help or feedback on this project, join us on [gitter][gitter-url] | ||
|
|
||
| ## License | ||
|
|
||
| Apache 2.0 - See [LICENSE][license-url] for more information. | ||
|
|
||
| [gitter-image]: https://badges.gitter.im/open-telemetry/opentelemetry-js.svg | ||
| [gitter-url]: https://gitter.im/open-telemetry/opentelemetry-node?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge | ||
| [license-url]: https:/open-telemetry/opentelemetry-js/blob/master/LICENSE | ||
| [license-image]: https://img.shields.io/badge/license-Apache_2.0-green.svg?style=flat | ||
| [dependencies-image]: https://david-dm.org/open-telemetry/opentelemetry-js/status.svg?path=metapackages/plugins-node-core | ||
| [dependencies-url]: https://david-dm.org/open-telemetry/opentelemetry-js?path=packages%2Fopentelemetryplugins-node-core | ||
| [npm-url]: https://www.npmjs.com/package/@opentelemetry/plugins-node-core | ||
| [npm-img]: https://badge.fury.io/js/%40opentelemetry%2Fplugins-node-core.svg | ||
|
|
||
| [otel-plugins-node-core]: https://www.npmjs.com/package/@opentelemetry/plugins-node-core | ||
|
|
||
| [otel-plugin-dns]: https:/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-dns | ||
| [otel-plugin-express]: https:/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-express | ||
| [otel-plugin-ioredis]: https:/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-ioredis | ||
| [otel-plugin-mongodb]: https:/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-mongodb | ||
| [otel-plugin-mysql]: https:/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-mysql | ||
| [otel-plugin-pg-pool]: https:/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-pg-pool | ||
| [otel-plugin-pg]: https:/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-pg | ||
| [otel-plugin-redis]: https:/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-redis | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
|
There was a problem hiding this comment. I put this in metapackages to be consistent with where/how it was organized in opentelemetry-js. An argument could be made for nesting somewhere in plugins but I do see value in surfacing up it is a package of packages. I'm open to suggestions if the current approach is not preferred (or we can always tweak later). |
||
| "name": "@opentelemetry/plugins-node-all", | ||
| "version": "0.10.2", | ||
| "description": "Metapackage which bundles opentelemetry node core and contrib plugins", | ||
| "author": "OpenTelemetry Authors", | ||
| "homepage": "https:/open-telemetry/opentelemetry-js#readme", | ||
| "license": "Apache-2.0", | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https:/open-telemetry/opentelemetry-js.git" | ||
| }, | ||
| "bugs": { | ||
| "url": "https:/open-telemetry/opentelemetry-js/issues" | ||
| }, | ||
| "dependencies": { | ||
| "@opentelemetry/plugin-express": "0.9.0", | ||
| "@opentelemetry/plugin-ioredis": "0.9.0", | ||
| "@opentelemetry/plugin-mongodb": "0.9.0", | ||
| "@opentelemetry/plugin-mysql": "0.9.0", | ||
| "@opentelemetry/plugin-pg": "0.9.0", | ||
| "@opentelemetry/plugin-pg-pool": "0.9.0", | ||
| "@opentelemetry/plugin-redis": "0.9.0", | ||
| "@opentelemetry/plugins-node-core": "^0.10.2" | ||
|
There was a problem hiding this comment. It is my understanding this gets tweaked on release, so I did not touch this area to deal with the current issue. I assume this will get resolved when we release/publish. Let me know if that is not the right approach. There was a problem hiding this comment. i think we can bump this to There was a problem hiding this comment. @michaelgoin can you resolve this then we can merge? |
||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed like the only place that likely needing something added. Nothing in the CircleCI setup seemed like it would need tweaking but perhaps I missed something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add metapackages to the lerna.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant with regards to the CI configuration files (circle VS actions). I did add to lerna.json with this PR but definitely double-check I did correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry I just saw "This seemed like the only place that likely needing something added" and my brain was on autopilot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. I definitely should have been clearer.