Ioredis cleanup #194
Merged
Ioredis cleanup #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 95.22% 95.22% -0.01%
==========================================
Files 93 93
Lines 4750 4749 -1
Branches 492 492
==========================================
- Hits 4523 4522 -1
Misses 227 227
|
vmarchaud
approved these changes
Sep 2, 2020
obecny
reviewed
Sep 8, 2020
There was a problem hiding this comment.
@naseemkullah can you please do the same here as with redis (just add type etc.)
Signed-off-by: Naseem <[email protected]>
naseemkullah
force-pushed
the
ioredis-cleanup
branch
from
b3da797
to
54161a0
Compare
sure, done @obecny |
obecny
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
IoredisPluginClientTypesimport typewhere applicable