Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): lock file maintenance #2225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 20, 2024

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team May 20, 2024 00:23
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label May 20, 2024
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from ec08f63 to 9d253d0 Compare May 24, 2024 23:22
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 3 times, most recently from b75f7ae to f9b8733 Compare June 11, 2024 13:12
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 3 times, most recently from 70575b9 to 52ad4a5 Compare July 3, 2024 17:02
@trentm
Copy link
Contributor

trentm commented Jul 4, 2024

npm run compile fails with:

 ../../node_modules/@types/react/index.d.ts:36:53 - error TS7016: Could not find a declaration file for module 'scheduler/tracing'. '/home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/node_modules/scheduler/tracing.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/scheduler` if it exists or add a new declaration (.d.ts) file containing `declare module 'scheduler/tracing';`

36 import { Interaction as SchedulerInteraction } from "scheduler/tracing";
                                                       ~~~~~~~~~~~~~~~~~~~

This is the same issue that Martin hit in #2299 recently, explained here:
#2299 (comment)

tl;dr: I'm pretty sure (I haven't checked yet because yah 23k line package-lock.json diff!) the update includes an update to @types/scheduler (a minor update, but it is in 0.x range) that breaks the @types/react that uses it. I'm guessing that @types/react was not updated. The latest @types/react includes a fix to its dependency range on @types/scheduler that should fix the issue.

@trentm
Copy link
Contributor

trentm commented Jul 4, 2024

tl;dr: I'm pretty sure (I haven't checked yet because yah 23k line package-lock.json diff!) the update includes ...

Confirmed, the diff includes:

     "node_modules/@types/scheduler": {
-      "version": "0.16.8",
-      "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.8.tgz",
-      "integrity": "sha512-WZLiwShhwLRmeV6zH+GkbOFT6Z6VklCItrDioxUnv+u4Ll+8vKeFySoFyK/0ctcRpOmwAicELfmys1sDc/Rw+A==",
+      "version": "0.23.0",
+      "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.23.0.tgz",
+      "integrity": "sha512-YIoDCTH3Af6XM5VuwGG/QL/CJqga1Zm3NkU3HZ4ZHK2fRMPYP1VczsTUqtsf43PH/iJNVlPHAo2oWX7BSdB2Hw==",
       "dev": true
     },

but @types/react is still at the version that doesn't have the fix for this:

% git branch --list
* renovate/lock-file-maintenance
  main

% npm ls --package-lock-only @types/scheduler
[email protected] /Users/trentm/tm/opentelemetry-js-contrib11
└─┬ @opentelemetry/[email protected] -> ./plugins/web/opentelemetry-plugin-react-load
  └─┬ @types/[email protected]
    └── @types/[email protected]

@types/[email protected] has a fix. Can we tell renovate to update that dep as well?
Oh, we'd need to update the pinned version at

@pichlermarc Would we prefer that is done in a separate PR? Or update (some of) those devDependencies to caret ranges?

@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from 6d55919 to 2736d62 Compare July 29, 2024 14:35
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 3 times, most recently from 532b1a3 to 040c9e7 Compare August 20, 2024 20:54
@renovate-bot renovate-bot requested a review from a team as a code owner September 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants