Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Azure Functions Detector Collected Attributes #2233

Conversation

JacksonWeber
Copy link
Contributor

Short description of the changes

  • This PR updates the fields collected by the Azure Functions resource detector to be in line with Azure Functions' expectations. Fixes improper population of fields like faas.name and properly populates service.name instead for example. We also now collect the process PID and cloud resource ID.
  • These changes come with updated tests & README.

@JacksonWeber JacksonWeber requested a review from a team May 22, 2024 17:00
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (dfb2dff) to head (b99da1c).
Report is 147 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
- Coverage   90.97%   90.40%   -0.58%     
==========================================
  Files         146      149       +3     
  Lines        7492     7514      +22     
  Branches     1502     1573      +71     
==========================================
- Hits         6816     6793      -23     
- Misses        676      721      +45     
Files Coverage Δ
...tor-azure/src/detectors/AzureAppServiceDetector.ts 100.00% <100.00%> (+3.33%) ⬆️
...ctor-azure/src/detectors/AzureFunctionsDetector.ts 100.00% <100.00%> (ø)
...opentelemetry-resource-detector-azure/src/utils.ts 100.00% <100.00%> (ø)

... and 49 files with indirect coverage changes

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pichlermarc pichlermarc merged commit 7272ca8 into open-telemetry:main May 31, 2024
19 checks passed
@dyladan dyladan mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants