feat(detector-aws): add DetectorSync implementation for ECS detector #2331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Another PR moving away from the deprecated
Detector
interface in favour to theDetectorSync
interface. This time is for AWS ECS detector and it might help a bit in open-telemetry/opentelemetry-js#3582Not doing all detectors at once:
Short description of the changes
AwsEcsDetectorSync
class and instanceAwsEcsDetector
reuse the new sync instanceNote: since this package is marked as stable (major version is 1) we are doing a non breaking change by adding the new class and mark the current as
deprecated
. The async detector changes behavior, it does not throw anymore, and it was discussed in last SIG meeting (2024-07-31). The outcome was we're okay with that.A couple of PRs will follow: