ci: update mssql server image #2446
Conversation
pichlermarc
changed the title
github-actions
bot
added
pkg:instrumentation-ioredis
pkg:instrumentation-mysql
pkg:instrumentation-mysql2
pkg:resource-detector-alibaba-cloud
pkg:resource-detector-aws
pkg:resource-detector-gcp
pkg:resource-detector-instana
pkg:propagation-utils
pkg:instrumentation-amqplib
pkg:instrumentation-lru-memoizer
pkg:instrumentation-mongoose
pkg:instrumentation-tedious
pkg:instrumentation-aws-sdk
pkg:instrumentation-cassandra-driver
pkg:instrumentation-fastify
pkg:instrumentation-koa
pkg:instrumentation-memcached
pkg:instrumentation-mongodb
labels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2446 +/- ##
==========================================
- Coverage 90.97% 90.75% -0.23%
==========================================
Files 146 156 +10
Lines 7492 7700 +208
Branches 1502 1583 +81
==========================================
+ Hits 6816 6988 +172
- Misses 676 712 +36 |
| env: | ||
| SA_PASSWORD: mssql_passw0rd | ||
| ACCEPT_EULA: Y | ||
| ports: | ||
| - 1433:1433 | ||
| options: >- | ||
| --health-cmd "/opt/mssql-tools/bin/sqlcmd -U sa -P $SA_PASSWORD -Q 'select 1' -b -o /dev/null" | ||
| --health-cmd "/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P $SA_PASSWORD -C -Q 'select 1' -b -o /dev/null" |
There was a problem hiding this comment.
note for reviewers: that's the path from MSSQL server 2018 and up - as we're using MSSQL server 2022 I assumed there would be a /opt/mssql-tools22/ directory but inspecting the file system of a running container shows that there's only /opt/mssql-tools18/
-C ignores the self-signed certificate
There was a problem hiding this comment.
The best docs I've found for this image is the "Overview" section here: https://hub.docker.com/r/microsoft/mssql-server
Note Starting with SQL Server 2022 CU 14, we are updating SQL Server 2022 container images to include the new mssql-tools18 package. With the introduction of SQL Server 2022 CU 14, and in all future container images, the previous directory /opt/mssql-tools/bin will be phased out.
Where by "phased out" they mean: just gone. ;)
The version for the "mssql-tools" dir is, at least somewhat, independent of the mssql-server package. I believe that's why it is "mssql-tools18" even for versions of MSSQL server beyond 2018.
|
Note: I've noticed that |
There was a problem hiding this comment.
FWIW, the SA_PASSWORD envvar is (long since) deprecated in favour of MSSQL_SA_PASSWORD.
https://learn.microsoft.com/en-us/sql/linux/sql-server-linux-configure-environment-variables?view=sql-server-2017
However, that could be updated in a separate PR.
| env: | ||
| SA_PASSWORD: mssql_passw0rd | ||
| ACCEPT_EULA: Y | ||
| ports: | ||
| - 1433:1433 | ||
| options: >- | ||
| --health-cmd "/opt/mssql-tools/bin/sqlcmd -U sa -P $SA_PASSWORD -Q 'select 1' -b -o /dev/null" | ||
| --health-cmd "/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P $SA_PASSWORD -C -Q 'select 1' -b -o /dev/null" |
There was a problem hiding this comment.
The best docs I've found for this image is the "Overview" section here: https://hub.docker.com/r/microsoft/mssql-server
Note Starting with SQL Server 2022 CU 14, we are updating SQL Server 2022 container images to include the new mssql-tools18 package. With the introduction of SQL Server 2022 CU 14, and in all future container images, the previous directory /opt/mssql-tools/bin will be phased out.
Where by "phased out" they mean: just gone. ;)
The version for the "mssql-tools" dir is, at least somewhat, independent of the mssql-server package. I believe that's why it is "mssql-tools18" even for versions of MSSQL server beyond 2018.
…' helper to same 2022-latest tag THis isn't critical. This startDocker() helper is only used for local dev testing.
Tests are currently failing as the Microsoft SQL Server 2017 container fails to initialize, see #2445.
This seems to be caused by microsoft/mssql-docker#899
Since that image is already way outdated anyway, this PR updates the image to Microsoft SQL Server 2022.