Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-pg): add operation name attribute to db duration metric #2475

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add the required attribute of operation name. This PR uses the same function already being used to name the span with the operation name

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (a558044) to head (468e8cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2475   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         156      156           
  Lines        7725     7728    +3     
  Branches     1588     1590    +2     
=======================================
+ Hits         7010     7013    +3     
  Misses        715      715           
Files with missing lines Coverage Δ
...elemetry-instrumentation-pg/src/instrumentation.ts 89.83% <100.00%> (+0.17%) ⬆️
...node/opentelemetry-instrumentation-pg/src/utils.ts 97.63% <100.00%> (ø)

@pichlermarc pichlermarc merged commit b043ffb into open-telemetry:main Oct 15, 2024
20 checks passed
@dyladan dyladan mentioned this pull request Oct 15, 2024
@maryliag maryliag deleted the db-operation-attr branch October 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants