Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update eslint to use flat config (#1635) #2487

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

walter-0
Copy link

@walter-0 walter-0 commented Oct 16, 2024

Which problem is this PR solving?

Short description of the changes

  • Upgrades eslint, @typescript-eslint, and all related plugins
  • Rewrites the root eslint config to use the flat style
  • Updates lint script in each package.json
  • Removes all deprecated .eslintignores
  • Removes all eslintrc.js files within each package
  • Cleans up the eslint plugins and rules to remove deprecated ones
  • Adds @copyright and @license JSDoc tags to header comment.

Copy link

linux-foundation-easycla bot commented Oct 16, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Author

@walter-0 walter-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm a new contributor and I have a couple of questions to get this ready.
I updated eslint and ran lint:fix on everything, but there are still some typescript related linting errors. Many of them are no-explicit-any, no-missing-import. What is the convention for type-related linting errors, and other code smells such as unused-vars, no-unsafe-function-type.
I think the no-missing-import may have something to do with the root tsconfig using moduleResolution: node, which probably should be considered deprecated since it's for Node versions older than v10. I wasn't able to get that working on my end, but perhaps there's something I'm not aware of with this project.

Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:auto-configuration-propagators pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:host-metrics pkg:id-generator-aws-xray pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-document-load pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-redis-4 pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-undici pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:plugin-react-load pkg:propagation-utils pkg:propagator-instana pkg:propagator-ot-trace pkg:redis-common pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-gcp pkg:resource-detector-github pkg:resource-detector-instana pkg:sampler-aws-xray pkg:sql-common pkg:test-utils pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade eslint to flat config