-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update eslint to use flat config (#1635) #2487
base: main
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm a new contributor and I have a couple of questions to get this ready.
I updated eslint and ran lint:fix on everything, but there are still some typescript related linting errors. Many of them are no-explicit-any
, no-missing-import
. What is the convention for type-related linting errors, and other code smells such as unused-vars
, no-unsafe-function-type
.
I think the no-missing-import
may have something to do with the root tsconfig using moduleResolution: node
, which probably should be considered deprecated since it's for Node versions older than v10. I wasn't able to get that working on my end, but perhaps there's something I'm not aware of with this project.
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
Which problem is this PR solving?
Short description of the changes
@copyright
and@license
JSDoc tags to header comment.