Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing async resolvers for graphql #300

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Jan 5, 2021

Which problem is this PR solving?

Short description of the changes

  • Fixing the async resolvers

@obecny obecny added the bug Something isn't working label Jan 5, 2021
@obecny obecny self-assigned this Jan 5, 2021
@obecny obecny requested a review from a team January 5, 2021 00:22
@obecny obecny changed the title chore: fixing async resolvers chore: fixing async resolvers for graphql Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #300 (776262a) into master (31d7bee) will decrease coverage by 0.02%.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   95.35%   95.33%   -0.03%     
==========================================
  Files         115      115              
  Lines        5991     5998       +7     
  Branches      591      592       +1     
==========================================
+ Hits         5713     5718       +5     
- Misses        278      280       +2     
Impacted Files Coverage Δ
...opentelemetry-instrumentation-graphql/src/utils.ts 95.18% <77.77%> (-1.05%) ⬇️
...metry-instrumentation-graphql/test/graphql.test.ts 100.00% <100.00%> (ø)

@obecny obecny merged commit e3de6ba into open-telemetry:master Jan 8, 2021
@obecny obecny deleted the graphql_295 branch January 8, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL plugin: not waiting for promises in execute and resolve steps
4 participants