moving dev dependency for types to main dependency

[obecny]

moving dev dependency for types to main dependency

[dyladan]

Is this intentional?

[obecny]

yes

[dyladan]

If we don't have at least ^ we might get a version that is incompatible with us and users will fail to compile until we release an update. This is very dangerous

[obecny]

If we don't have at least ^ we might get a version that is incompatible with us and users will fail to compile until we release an update. This is very dangerous

* is what @Flarna requested looks like it is not working

[Flarna]

I tried '*' locally in a hapi and aws-lambda instrumentation and it worked. But most likely I tried the wrong thing...
It's used on default in @types packages from DefinitelyTyped.

Which error happened?

[dyladan]

I wouldn't expect an error but it looks like there was a force push so i can't see the old test run.

@Flarna it was mentioned you requested *. Do you think we shouldn't worry about the issue I mentioned above where a breaking change might break our users until we push a new release?

[Flarna]

Ah ok, I misunderstood the message above.

If we use * it means we accept any version and if nothing is specified the latest available is used. On consume side it means it will be always deduped and they don't get two versions installed.

Clearly * has the potential to break our CI where the actual build step is running. But using ^ may also break our CI because @types packages don't follow semver therefore even a patch version may break something.

On user side the opentelemetry packages are not transpiled anymore therefore the version should not matter.

So far my understanding... but honestly speaking types I'm not sure if I get all corner cases.
@types packages can be beasts sometimes - as we have recently seen here with the hapi/hapi-podium types.

[Flarna]

Just to be clear regarding my request: I'm fine with all variants to solve this as all of them may require to tune later.

[dyladan]

maybe we should even do ~. We have seen with the metapackage that the typescript compiler is checking transitive type dependencies otherwise we wouldn't have this issue.

Honestly I think keeping pinned versions is the safest for the time being.

[codecov]

Codecov Report

Merging #468 (3294280) into main (2cbf8e7) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   95.20%   95.32%   +0.12%     
==========================================
  Files         131      127       -4     
  Lines        8279     8092     -187     
  Branches      790      776      -14     
==========================================
- Hits         7882     7714     -168     
+ Misses        397      378      -19     

Impacted Files	Coverage Δ
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts
...ges/opentelemetry-host-metrics/test/metric.test.ts
packages/opentelemetry-host-metrics/src/metric.ts
...ges/opentelemetry-host-metrics/src/stats/common.ts
packages/opentelemetry-host-metrics/src/enum.ts
...ackages/opentelemetry-host-metrics/src/stats/si.ts
packages/opentelemetry-host-metrics/src/version.ts
...metry-instrumentation-document-load/src/version.ts	100.00% <0.00%> (ø)
...entation-document-load/src/enums/AttributeNames.ts	100.00% <0.00%> (ø)
...-instrumentation-document-load/src/documentLoad.ts	99.00% <0.00%> (ø)