Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing usage of timed event from api #470

Merged
merged 3 commits into from
May 8, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented May 4, 2021

Which problem is this PR solving?

  • Removing dependency on TimedEvent from api

Short description of the changes

@obecny obecny added the enhancement New feature or request label May 4, 2021
@obecny obecny self-assigned this May 4, 2021
@obecny obecny requested a review from a team May 4, 2021 20:05
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #470 (e4665e5) into main (1386d75) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   95.20%   95.28%   +0.08%     
==========================================
  Files         131      131              
  Lines        8271     8108     -163     
  Branches      790      751      -39     
==========================================
- Hits         7874     7726     -148     
+ Misses        397      382      -15     
Impacted Files Coverage Δ
...ntelemetry-instrumentation-pg/test/pg-pool.test.ts 89.51% <ø> (ø)
...e/opentelemetry-instrumentation-pg/test/pg.test.ts 94.42% <ø> (ø)
...ation-user-interaction/src/enums/AttributeNames.ts
...ry-instrumentation-user-interaction/src/version.ts
...umentation-user-interaction/src/userInteraction.ts
...-instrumentation-document-load/src/documentLoad.ts 99.00% <0.00%> (ø)
...entation-document-load/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...metry-instrumentation-document-load/src/version.ts 100.00% <0.00%> (ø)

@obecny obecny requested a review from dyladan May 6, 2021 17:13
@vmarchaud vmarchaud merged commit 60c015a into open-telemetry:main May 8, 2021
@obecny obecny deleted the te branch May 10, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider hiding/moving Event/TimedEvent
4 participants