fixup! feat(instrumentation): added synchronous gauge to SDK

open-telemetry · Mar 23, 2024 · 95f7f66 · 95f7f66
1 parent 3aaf51e
commit 95f7f66
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/sdk-metrics/src/Instruments.ts b/packages/sdk-metrics/src/Instruments.ts
@@ -22,7 +22,6 @@ import {
  ValueType,
  UpDownCounter,
  Counter,
- Gauge,
  Histogram,
  Observable,
  ObservableCallback,
@@ -37,6 +36,7 @@ import {
  AsyncWritableMetricStorage,
  WritableMetricStorage,
 } from './state/WritableMetricStorage';
+import { Gauge } from './types';
 
 export class SyncInstrument {
  constructor(

diff --git a/packages/sdk-metrics/src/types.ts b/packages/sdk-metrics/src/types.ts
@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+import { Context, MetricAttributes } from '@opentelemetry/api';
 
 export type CommonReaderOptions = {
  timeoutMillis?: number;
@@ -23,3 +24,13 @@ export type CollectionOptions = CommonReaderOptions;
 export type ShutdownOptions = CommonReaderOptions;
 
 export type ForceFlushOptions = CommonReaderOptions;
+
+// NOTE: This is here because of the strange dependency on api?
+export interface Gauge<
+ AttributesTypes extends MetricAttributes = MetricAttributes,
+> {
+ /**
+ * Records a measurement. Value of the measurement must not be negative.
+ */
+ record(value: number, attributes?: AttributesTypes, context?: Context): void;
+}