Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ALWAYS_PARENT sampler with ParentOrElse sampler #1075

Closed
dyladan opened this issue May 18, 2020 · 2 comments · Fixed by #1279
Closed

Replace ALWAYS_PARENT sampler with ParentOrElse sampler #1075

dyladan opened this issue May 18, 2020 · 2 comments · Fixed by #1279
Assignees
@legendecas

Comments

@dyladan
Copy link
Member

dyladan commented May 18, 2020

open-telemetry/opentelemetry-specification#609
@dyladan dyladan added Discussion Issue or PR that needs/is extended discussion. required-by-spec labels May 18, 2020
@legendecas legendecas mentioned this issue May 27, 2020
Merged
@dyladan
Copy link
Member Author

dyladan commented May 27, 2020

@legendecas if you're going to work on this, comment here so I can assign you.

@dyladan dyladan removed the Discussion Issue or PR that needs/is extended discussion. label May 27, 2020
@legendecas
Copy link
Member

:) definitely

@legendecas legendecas mentioned this issue Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legendecas legendecas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ParentOrElseSampler legendecas/opentelemetry-js
2 participants
@dyladan @legendecas