Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP semantic convention for content size #1249

Closed
dyladan opened this issue Jun 26, 2020 · 6 comments · Fixed by #1625
Closed

Add HTTP semantic convention for content size #1249

dyladan opened this issue Jun 26, 2020 · 6 comments · Fixed by #1625
Assignees

Comments

@dyladan
Copy link
Member

dyladan commented Jun 26, 2020

open-telemetry/opentelemetry-specification#641

This will need to be added to the HTTP and HTTPS plugins, as well as to the Semantic Conventions module.

@obecny obecny added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Aug 18, 2020
@dyladan dyladan self-assigned this Sep 2, 2020
@dyladan dyladan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Sep 2, 2020
@dyladan dyladan removed their assignment Sep 2, 2020
@michaelgoin
Copy link
Contributor

Per meeting, I can grab this.

@dyladan
Copy link
Member Author

dyladan commented Sep 2, 2020

Oops looks like i assigned @obecny instead of @michaelgoin

@dyladan dyladan assigned michaelgoin and unassigned obecny Sep 2, 2020
@carlo-808
Copy link
Contributor

Greetings, I work with @michaelgoin at New Relic and he and I both decided I could take this issue to get more familiar with the project. Can someone assign me this issue? I'm looking forward to contributing to the project. Thanks!

@michaelgoin michaelgoin removed their assignment Sep 25, 2020
@carlo-808
Copy link
Contributor

@dyladan I have some questions about this issue. Should we be calculating the value for request_content_length or just use the content-length header value to populate request_content_length? For request_content_length_uncompressed, do we populate this value with the content-length header if no transport encoding is used OR should it be calculated as well?

@dyladan
Copy link
Member Author

dyladan commented Oct 21, 2020

For request_content_length, simply using the header value should be fine. I'm not that familiar with the available headers but I think uncompressed will need to be calculated.

@nijotz
Copy link
Contributor

nijotz commented Oct 26, 2020

PR #1625 opened to add this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants