Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert grpc plugin to instrumentation #1656

Closed
obecny opened this issue Nov 5, 2020 · 0 comments · Fixed by #1744
Closed

Convert grpc plugin to instrumentation #1656

obecny opened this issue Nov 5, 2020 · 0 comments · Fixed by #1744
Assignees

Comments

@obecny
Copy link
Member

obecny commented Nov 5, 2020

  • Change folder name from opentelemetry-plugin-* to opentelemetry-instrumentation-*
  • Change package name from @opentelemetry/plugin-* to @opentelemetry/instrumentation-*
  • Change implementation to use InstrumentationBase
@obecny obecny added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 5, 2020
@vmarchaud vmarchaud self-assigned this Dec 5, 2020
@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Dec 5, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 12, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 16, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 19, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 27, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 5, 2021
dyladan added a commit that referenced this issue Jan 6, 2021
dyladan added a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
dyladan added a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants