Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric API: Ability to create histograms like prometheus histograms #1703

Closed
sureshballa opened this issue Nov 30, 2020 · 6 comments
Closed

Comments

@sureshballa
Copy link

Do we have ability to create histograms like prometheus histograms from metrics API?

@dyladan
Copy link
Member

dyladan commented Dec 2, 2020

Not yet. Likely this will be just an aggregator on the value recorder but we're waiting for the spec to finalize this.

@sureshballa
Copy link
Author

Just wanted to check if we have any update on this. Or a sample code of how we can leverage value recorder to implement histograms.

@locmai
Copy link

locmai commented Oct 11, 2021

@sureshballa this PR provides that histogram aggregation #1628 , I have tried with the prometheus exporter and have no issue so far:

const valueRecorder = meter.createValueRecorder("request_processing_seconds", {
  description: "Time spent processing request",
  boundaries: [0, 1, 10 , 50 ,95 , 99, 100, Infinity],
});

@sureshballa
Copy link
Author

Thanks, @locmai , is this released for consumption?

@smith
Copy link

smith commented Apr 29, 2022

I think this can be closed.

@legendecas
Copy link
Member

legendecas commented Apr 30, 2022

Histogram type instrument has been implemented in the latest metrics SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants