Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleSpanProcessor.forceFlush doesn't wait for pending exports #1841

Open
anuraaga opened this issue Jan 18, 2021 · 1 comment
Open

SimpleSpanProcessor.forceFlush doesn't wait for pending exports #1841

anuraaga opened this issue Jan 18, 2021 · 1 comment
Labels
priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug

Comments

@anuraaga
Copy link
Contributor

While examining aws-observability/aws-otel-community#17, I noticed that SimpleSpanProcessor.forceFlush doesn't allow blocking on pending exports.

opentelemetry-js/packages/opentelemetry-tracing/src/export/SimpleSpanProcessor.ts

Line 37 in 392c43f

// do nothing as all spans are being exported without waiting

Presumably, onEnd needs to store the Promise for the call to export in some Set-like object which is removed from when the export completes, so that forceFlush can block on the promises in that set.
@anuraaga anuraaga added the bug Something isn't working label Jan 18, 2021
@dyladan dyladan added spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug and removed bug Something isn't working labels Jul 20, 2022
@dyladan
Copy link
Member

dyladan commented Jul 20, 2022

Related to #3067. This is not a bug but a spec inconsistency. This can't be fixed until #3067 is resolved.

@dyladan dyladan added the priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anuraaga @dyladan