Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate exporter-collector-grpc to grpc-js #2087

Closed
anuraaga opened this issue Apr 8, 2021 · 1 comment · Fixed by #2092
Closed

Migrate exporter-collector-grpc to grpc-js #2087

anuraaga opened this issue Apr 8, 2021 · 1 comment · Fixed by #2092
Assignees

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Apr 8, 2021

I noticed that grpc-native is deprecated and will end support this month.

https://www.npmjs.com/package/grpc

They stopped uploading prebuilt binaries many versions ago so it's always an unfortunately slow process using it in node builds now adays as well. Is it possible to migrate to grpc-js?

One concern may be version compatibility - while it's not as widely compatible, it does seem to support at least the latest minor of every LTS since 8.x

https:/grpc/grpc-node/blob/master/packages/grpc-js/package.json#L9

@vmarchaud
Copy link
Member

Someone opened a PR (here) in the past to migrate but didn't complete it because of a bug i believe

@vmarchaud vmarchaud added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Apr 8, 2021
@obecny obecny self-assigned this Apr 9, 2021
@obecny obecny removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants