-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improv: naming sdks #2146
Labels
Comments
vmarchaud
added
feature-request
Discussion
Issue or PR that needs/is extended discussion.
labels
Apr 22, 2021
I'd name them from ordering tokens("isSdk", platform, bundle type) from general to specific:
In that way it's simple to see all variants for a sdk, and most likely, when installing one, you know which platform you are looking for as well. |
cc @open-telemetry/javascript-approvers |
dyladan
added
the
up-for-grabs
Good for taking. Extra help will be provided by maintainers
label
Jun 30, 2021
vmarchaud
removed
the
up-for-grabs
Good for taking. Extra help will be provided by maintainers
label
Jul 11, 2021
vmarchaud
added a commit
that referenced
this issue
Aug 5, 2021
Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed at the SIG, its really confusing to have the sdk term for
@opentelemetry/node
and@opentelemetry/web
(which are the tracing sdks) and the "sdk" term of package with more components (ex:@opentelemetry/sdk-node
).I think we should have:
@opentelemetry/node-tracing
which is the node tracing sdk@opentelemetry/browser-tracing
which is the browser tracing sdk@opentelemetry/node-sdk
which bundle every signal SDKs@opentelemetry/browser-sdk
same as node sdk but for browser@opentelemetry/node-sdk-all
with all components as dependencies@opentelemetry/browser-sdk-all
with all components as dependenciesThe text was updated successfully, but these errors were encountered: