-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove http.route from http span attributes #2489
Comments
Note that we override it if another instrumentation (for http frameworks) has given the low cardinality route https:/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation-http/src/utils.ts#L494 |
that's fine but if you're not using one of those instrumentations then it's a duplicated field (with http.target) so there's no reason to have it. |
@dyladan I can work on this, please assign this to me. |
It seems to me we should actually not be setting the route parameter.
Originally posted by @dyladan in #2487 (comment)
According to the spec, the http.route parameter should be the low-cardinality template route like
/user/:id
. In the http instrumentation, we don't have access to that information and we populate the whole route like/user/123
but that information is already available in thehttp.target
attribute.The text was updated successfully, but these errors were encountered: