-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API version required by SDK #2769
Labels
Comments
This was referenced Feb 7, 2022
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Refs: #2892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #2737 API range was extended from
>=1.0.0 <1.1.0
to>=1.0.0 <1.2.0
to add support for 1.1 but keep compatible as much as possible.Unfortunately this resulted in broken CI for nodejs 16 (see #2755).
In #2759 API version range in SDKs was narrowed to
>=1.1.0 <1.2.0
to fix the CI.I think we should clarify how to continue here and if more changes then hat one done in #2759 are needed to stay consistent or if we should revert it and solve the CI problem in a different way.
In general allowing SDK to use an 1.0 API seems to be problematic as it avoids that e.g. instrumentation use API 1.1. Reason is that SDK registers TracerProvider,.. in version 1.0 and the version check in API doesn't accept newer minor (only olders).
The text was updated successfully, but these errors were encountered: