New resource detectors import "os" which doesn't work in browsers

[blumamir]

What version of OpenTelemetry are you using?

1.3.0

What version of Node are you using?

12

Versions 1.3.0 of stable added new resource detectors to @opentelemetry/resources: "OsDetector" and "HostDetector". They both "import {..} from 'os' which makes contrib tests fail with message:

Module not found: Error: Can't resolve 'os' in '/home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/plugins/web/opentelemetry-instrumentation-document-load/node_modules/@opentelemetry/resources/build/esm/detectors'

Are these detectors meant to be used in the browser? As far as I understand, the @opentelemetry/resources package is supposed to be browser compatible, do we need to handle these imports in any way to make it work? or make sure the detectors are not included in a browser distribution?

[jjhuff]

I noticed that I still have to tell webpack to ignore os:

  resolve: {
    fallback: { os: false },

The way I'm reading the code, it looks like the node versions always get imported?

I'm importing Resource like:
import { Resource } from '@opentelemetry/resources';

[blumamir]

I think the fix is merged but not yet published

[jjhuff]

I think it went out with 0.29.1: #3013

[blumamir]

I think it went out with 0.29.1: #3013

The version in npm is still 1.3.0: https://www.npmjs.com/package/@opentelemetry/resources

Looks like #3013 released experimental but not stable packages.
@dyladan - should we publish a release for 1.3.1?

[jjhuff]

oh! Yes, I apologize. I was looking at the wrong package

[blumamir]

@dyladan will publish stable packages later today.
Thank you for reporting