NodeSDK should register instrumentations earlier

[Flarna]

Is your feature request related to a problem? Please describe.

Instrumentations need to be registered before the corresponding module to instrument is loaded. Currently NodeSDK calls registerInstrumentations() as last step in start() (see here). This might lead to missing some modules to instrument es e.g. resource detection does already HTTP requests before.

Describe the solution you'd like

We should move registerInstrumentations() call to the beginning of start or even into constructor. Or maybe even remove this functionality from SDK and require user to do it before require the SDK.

Describe alternatives you've considered

Additional context

refs.: open-telemetry/opentelemetry-js-contrib#1109 (comment)

[dyladan]

I'm actually going to reclassify this as a bug since it definitely can cause problems. The node sdk package is something that was done experimentally a long time ago but now has gained quite some users and should be brought to the level of quality they expect

[AWare]

As an alternative, can I suggest that instrumentation be a pre-runtime step? Having all the instrumentations patched into node_modules where possible would really help with reliability- especially where bundlers are used.

[Flarna]

@AWare What do you mean in detail with pre-runtime step?

[Flarna]

@dyladan Even it's assigned to you I created a simple PR to improve this: #3502

[dyladan]

Thanks @Flarna I haven't had time to work on this so I appreciate that you handled it