-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc instrumentation requires @grpc/grpc-js types but doesn't depend on it #3548
Comments
Thinking that #3386 could be causing this issue, as it uses the types from grpc and grpc-js in the instrumentation's public API. Edit: looks like it is not actually using it in its public API, continuing to investigate. |
Took a look into the generated .d.ts files:
As a result any consumer requires moving |
I can create a PR as I have the changes already done local. |
Ah, right. Just came to the same conclusion, you beat me to it. Thanks for taking a look.
Please do, I'll give it a review right away. 🙂 |
This results in build failures if consumer has @grpc/grpc-js not installed for other reasons.
Refs: open-telemetry/opentelemetry-js-contrib#1358 (comment)
The text was updated successfully, but these errors were encountered: