-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otlp-transformer requires BigInt #4350
Comments
This kinda depends on decisions to be done in #4168 - likely anyting as old as IE would only be supported as not by default/user must add polyfills (be it with babel/preset-env w/ polyfills based on usage or whatever) Other browsers have good enough support for BigInt https://caniuse.com/bigint |
The use of BigInt within opentelemetry-js is a relatively recent change and localised entirely to the changes introduced from this PR. The PR even went to some effort to try and offer fallbacks when BigInt is unavailable (see here) but missed the I have a use case to support Chrome 40+ (but unfortunately below 67 where BigInt support is introduced). Given the near impossibility of polyfilling BigInt it would be nice if the |
What happened?
Steps to Reproduce
install
@opentelemetry/otlp-transformer
build bundle for browsers with opentelemetry tracing
Expected Result
@opentelemetry/otlp-transformer
fallbacks if BigInt not existsActual Result
it doesn't
https:/open-telemetry/opentelemetry-js/blob/main/experimental/packages/otlp-transformer/src/common/index.ts#L21
Additional Details
As temporary workaround include bigint polyfill unconditionally for old browsers
OpenTelemetry Setup Code
No response
package.json
Relevant log output
No response
The text was updated successfully, but these errors were encountered: