Fix circleci caching paths

[dyladan]

Is your feature request related to a problem? Please describe.

Circle CI caching paths include a * glob. According to the docs, globbing is not allowed in the paths array.

Describe the solution you'd like

Each package node module directory should be manually added to the globs array.

Please assign to me. PR incoming.

[dyladan]

While I'm working on this, should we remove yarn.lock files from the cache? I added them because there was a packages/*/yarn.lock line before, but it may be a good idea to remove them so that the ci builds always get the latest version of node modules permissible by the package.json

[vmarchaud]

yarn.lock files are inside the .gitignore so we shouldn't have any of them inside the repo. However i would argue that would be better to use them since the CI might install different deps version than we have in local.

[dyladan]

They are cached by the circle ci caching layer, so they are created and persisted between multiple test runs until the cache breaks (by changing a package.json file).

[vmarchaud]

Oh got it, for me which should either use them at every step (so commit them inside the repo) or not using them at all

[dyladan]

I would argue for not using them at all. We want to make sure we get the versions of dependencies that our end users will get. It is up to them to lock their dependencies.

[mayurkale22]

@dyladan Can we close this one?