Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge base into api #968

Closed
obecny opened this issue Apr 16, 2020 · 2 comments · Fixed by #991
Closed

merge base into api #968

obecny opened this issue Apr 16, 2020 · 2 comments · Fixed by #991
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@obecny
Copy link
Member

obecny commented Apr 16, 2020 •
edited
Loading

Currently the package base has just one constant and ExportResult which is a bit weird to be a standalone package, should we simply include this into api ?
@obecny obecny added the Discussion Issue or PR that needs/is extended discussion. label Apr 16, 2020
@dyladan
Copy link
Member

dyladan commented Apr 16, 2020

I think those can be moved into core, but they're both specific to our SDK so they can't be moved into the API

@obecny
Copy link
Member Author

obecny commented Apr 16, 2020

core works fine too

@legendecas legendecas mentioned this issue Apr 29, 2020
Merged
@dyladan dyladan added the Agreed label Apr 29, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@mentos1386
fix(instrumentation-aws-sdk): sqs message id missing on send command (o…
8b36fe1 
…pen-telemetry#968)

* test(instrumentation-aws-sdk): make sure that message id attribute is set on send command

* fix(instrumentation-aws-sdk): set message id on send command

* style(instrumentation-aws-sdk): lint fixes

* chore(instrumentation-aws-sdk): use optional chaining in case data is null

* test(instrumentation-aws-sdk): cover sdk v2 sqsResponseHook messaging attributes

* style: lint fix

* test(instrumentation-aws-sdk): make sure correct http status code is used

* test(instrumentation-aws-sdk): rename test to inlcude sendMessage

Co-authored-by: Amir Blum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: merge opentelemetry-base to opentelemetry-core legendecas/opentelemetry-js
2 participants
@obecny @dyladan