fix(opentelemetry-plugin-xml-http-request): define span kind as CLIENT for xmlhttprequests #1002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
xml-http-request
plugin does not correctly set the span kind toCLIENT
when creating the span on the open method. This makes all spans that represent XHR requests having the default span kind ofINTERNAL
.Per spec
INTERNAL -> Default value. Indicates that the span is used internally.
, which in this case is not true and should beCLIENT -> Indicates that the span covers the client-side wrapper around an RPC or other remote request.
.Short description of the changes
One-liner to set the span kind to
CLIENT
.